Skip to content

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Sep 29, 2019

Make cudnn rnn respect current stream. After this lands, non-default test stream can be reenabled in #26791

Test plan: default stream functionality is tested in existing tests, stream safety tests will be added in #26791

@ngimel ngimel requested a review from mruberry September 29, 2019 03:16
@pytorchbot pytorchbot added module: cudnn Related to torch.backends.cudnn, and CuDNN support module: operators labels Sep 29, 2019
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 2bcbc15.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 30, 2019
Summary:
Make cudnn rnn respect current stream. After this lands, non-default test stream can be reenabled in pytorch/pytorch#26791
Pull Request resolved: pytorch/pytorch#27026

Test Plan: default stream functionality is tested in existing tests, stream safety tests will be added in pytorch/pytorch#26791

Differential Revision: D17656967

Pulled By: ngimel

fbshipit-source-id: 8b051aedd1df089b21f666ec553a5acefffdac88
pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
Summary:
Make cudnn rnn respect current stream. After this lands, non-default test stream can be reenabled in pytorch#26791
Pull Request resolved: pytorch#27026

Test Plan: default stream functionality is tested in existing tests, stream safety tests will be added in pytorch#26791

Differential Revision: D17656967

Pulled By: ngimel

fbshipit-source-id: 8b051aedd1df089b21f666ec553a5acefffdac88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cudnn Related to torch.backends.cudnn, and CuDNN support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants