Skip to content

[ONNX] Export update for arange and _dim_arange #26875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neginraoof wants to merge 36 commits into from
Closed

[ONNX] Export update for arange and _dim_arange #26875

neginraoof wants to merge 36 commits into from

Conversation

@neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Sep 26, 2019

Export arange and _dim_arange using onnx::range in opset 11

@neginraoof neginraoof requested a review from apaszke as a code owner September 26, 2019 07:20
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx labels Sep 26, 2019
@pytorchbot pytorchbot added the module: ci Related to continuous integration label Sep 26, 2019
lara-hdr
lara-hdr reviewed Sep 26, 2019
View reviewed changes
lara-hdr
lara-hdr reviewed Sep 26, 2019
View reviewed changes
lara-hdr
lara-hdr reviewed Sep 26, 2019
View reviewed changes
@vincentqb vincentqb added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 26, 2019
facebook-github-bot
facebook-github-bot reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

spandantiwari
spandantiwari reviewed Sep 27, 2019
View reviewed changes
@spandantiwari spandantiwari self-requested a review September 27, 2019 17:14
spandantiwari
spandantiwari suggested changes Sep 27, 2019
View reviewed changes
Copy link

@spandantiwari spandantiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment in code. Thanks.

@spandantiwari spandantiwari mentioned this pull request Sep 30, 2019
Closed
houseroad
houseroad reviewed Oct 4, 2019
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

houseroad commented Oct 15, 2019

@pytorchbot retest this please

@houseroad
Copy link
Member

houseroad commented Oct 15, 2019

@pytorchbot rebase this please

houseroad
houseroad reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR manually. The bot is not functioning.

facebook-github-bot
facebook-github-bot reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

houseroad commented Oct 16, 2019

Segfault here: https://circleci.com/gh/pytorch/pytorch/3235244?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@neginraoof neginraoof force-pushed the neraoof/arange branch 2 times, most recently from 4eca8e3 to dd832c6 Compare October 16, 2019 23:46
neginraoof and others added 8 commits October 16, 2019 16:47
@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
bd9671f 
…oof/arange
Merge branch 'neraoof/arange' of https://github.com/neginraoof/pytorch …
b13f04b 
…into neraoof/arange
@neginraoof
Merge branch 'neraoof/arange' of https://github.com/neginraoof/pytorch …
d85b0dc 
…into neraoof/arange
@neginraoof
fix for no type tests
253e379
Merge branch 'neraoof/arange' of https://github.com/neginraoof/pytorch …
6c2811f 
…into neraoof/arange
skip type cast for opsets before 11
ca854ba
clean up
e776fc5
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
1d2b287 
…oof/arange
@neginraoof
Copy link
Contributor Author

neginraoof commented Oct 17, 2019

@houseroad this is updated and ready

facebook-github-bot
facebook-github-bot reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 18, 2019

@houseroad merged this pull request in 95922c9.

thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
@neginraoof
Export update for arange and _dim_arange (pytorch#26875)
d79e76e 
Summary:
Export arange and _dim_arange using onnx::range in opset 11
Pull Request resolved: pytorch#26875

Reviewed By: hl475

Differential Revision: D17623848

Pulled By: houseroad

fbshipit-source-id: 41f0066ca1c42882ccc051a3ee5448dca25ee5d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

@apaszke apaszke Awaiting requested review from apaszke

+2 more reviewers

@lara-hdr lara-hdr lara-hdr left review comments

@spandantiwari spandantiwari spandantiwari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: ci Related to continuous integration module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@neginraoof @lara-hdr @houseroad @facebook-github-bot @spandantiwari @ezyang @vincentqb @pytorchbot @mruberry