[android][scripts] Script for full android build to aars; script to run android tests #26833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: android
IvanKobzarev
force-pushed
the
ik_android_scripts_build_test
branch
2 times, most recently
from
60810d0 to
32e459f
Compare
IvanKobzarev
force-pushed
the
ik_android_scripts_build_test
branch
from
32e459f to
d4bfe80
Compare
ljk53
reviewed
Sep 25, 2019
ljk53
reviewed
Sep 25, 2019
ljk53
reviewed
Sep 25, 2019
ljk53
reviewed
Sep 25, 2019
ljk53
reviewed
Sep 25, 2019
IvanKobzarev
force-pushed
the
ik_android_scripts_build_test
branch
from
d4bfe80 to
e7c8a0c
Compare
ljk53
reviewed
Sep 26, 2019
ljk53
reviewed
Sep 30, 2019
| @@ -0,0 +1,96 @@ | |||
| #!/bin/bash | |||
| set -eux | |||
Contributor
There was a problem hiding this comment.
nit: the name of the script is a bit verbose - can we simple call it "build_pytorch_android.sh"?
you can put a comment here to describe what it does.
ljk53
approved these changes
Sep 30, 2019
IvanKobzarev
force-pushed
the
ik_android_scripts_build_test
branch
2 times, most recently
from
4590e78 to
ab68715
Compare
IvanKobzarev
force-pushed
the
ik_android_scripts_build_test
branch
from
ab68715 to
b8154df
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@IvanKobzarev merged this pull request in 47cd15c. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…ytorch#26833) Summary: 1. scripts/build_android_libtorch_and_pytorch_android.sh - Builds libtorch for android_abis (by default for all 4: x86, x86_64, armeabi-v7a, arm-v8a) but cab be specified only custom list as a first parameter e.g. "x86" - Creates symbolic links inside android/pytorch_android to results of the previous builds: `pytorch_android/src/main/jniLibs/${abi}` -> `build_android/install/lib` `pytorch_android/src/main/cpp/libtorch_include/${abi}` -> `build_android/install/include` - Runs gradle assembleRelease to build aar files proxy can be specified inside (for devservers) 2. android/run_tests.sh Running pytorch_android tests, contains instruction how to setup and run android emulator in headless and noaudio mode to run it on devserver proxy can be specified inside (for devservers) #Test plan Scenario to build x86 libtorch and android aars with it and run tests: ``` cd pytorch sh scripts/build_android_libtorch_and_pytorch_android.sh x86 sh android/run_tests.sh ``` Tested on my devserver - build works, tests passed Pull Request resolved: pytorch#26833 Differential Revision: D17673972 Pulled By: IvanKobzarev fbshipit-source-id: 8cb7c3d131781854589de6428a7557c1ba7471e9
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
…ytorch#26833) Summary: 1. scripts/build_android_libtorch_and_pytorch_android.sh - Builds libtorch for android_abis (by default for all 4: x86, x86_64, armeabi-v7a, arm-v8a) but cab be specified only custom list as a first parameter e.g. "x86" - Creates symbolic links inside android/pytorch_android to results of the previous builds: `pytorch_android/src/main/jniLibs/${abi}` -> `build_android/install/lib` `pytorch_android/src/main/cpp/libtorch_include/${abi}` -> `build_android/install/include` - Runs gradle assembleRelease to build aar files proxy can be specified inside (for devservers) 2. android/run_tests.sh Running pytorch_android tests, contains instruction how to setup and run android emulator in headless and noaudio mode to run it on devserver proxy can be specified inside (for devservers) #Test plan Scenario to build x86 libtorch and android aars with it and run tests: ``` cd pytorch sh scripts/build_android_libtorch_and_pytorch_android.sh x86 sh android/run_tests.sh ``` Tested on my devserver - build works, tests passed Pull Request resolved: pytorch#26833 Differential Revision: D17673972 Pulled By: IvanKobzarev fbshipit-source-id: 8cb7c3d131781854589de6428a7557c1ba7471e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds libtorch for android_abis (by default for all 4: x86, x86_64, armeabi-v7a, arm-v8a) but cab be specified only custom list as a first parameter e.g. "x86"
Creates symbolic links inside android/pytorch_android to results of the previous builds:
pytorch_android/src/main/jniLibs/${abi}->build_android/install/libpytorch_android/src/main/cpp/libtorch_include/${abi}->build_android/install/includeRuns gradle assembleRelease to build aar files
proxy can be specified inside (for devservers)
Running pytorch_android tests, contains instruction how to setup and run android emulator in headless and noaudio mode to run it on devserver
proxy can be specified inside (for devservers)
#Test plan
Scenario to build x86 libtorch and android aars with it and run tests:
Tested on my devserver - build works, tests passed