C++ API parity: AdaptiveMaxPool3d #26775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pbelevich
requested review from
ebetica,
goldsborough and
yf225
as code owners
This was referenced Sep 25, 2019
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Sep 25, 2019
[ghstack-poisoned]
yf225
approved these changes
Sep 26, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
Looks awesome, thanks @pbelevich !
yf225
requested changes
Sep 26, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
Oops sorry, seems like we are missing pretty print tests for AdaptiveMaxPool3d.
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Differential Revision: [D17627824](https://our.internmc.facebook.com/intern/diff/D17627824) [ghstack-poisoned]
Differential Revision: [D17627824](https://our.internmc.facebook.com/intern/diff/D17627824) [ghstack-poisoned]
Contributor
|
@pbelevich merged this pull request in 5aa01fd. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26775 Test Plan: Imported from OSS Differential Revision: D17627824 Pulled By: pbelevich fbshipit-source-id: c4ae077ea5575c5d1df795e74a0dcb74a695ad06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17627824