[jit] flip the "don't inline" switch #26706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been ready for some time, just waiting on services to push with the new code.
ZolotukhinM
approved these changes
Sep 24, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good to me!
What is our long-term plan regarding this? Is there a reason not to remove it completely eventually? It currently mixes "optimizations" and "post-IRgen" passes and I'd like to clean it up :)
Member
Author
|
Yep, we can remove. I'd prefer to leave the "switch-flipping" plumbing in for now just in case we need to flip it back in an emergency 😛 |
zdevito
approved these changes
Sep 25, 2019
This has been ready for some time, just waiting on services to push with the new code. Differential Revision: [D17543304](https://our.internmc.facebook.com/intern/diff/D17543304)
This has been ready for some time, just waiting on services to push with the new code. Differential Revision: [D17543304](https://our.internmc.facebook.com/intern/diff/D17543304)
Contributor
|
This pull request has been merged in 0e441dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This has been ready for some time, just waiting on services to push with
the new code.
Differential Revision: D17543304