Skip to content

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Sep 21, 2019

Stack from ghstack:

Differential Revision: D17517468

Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
@yf225
Copy link
Contributor Author

yf225 commented Sep 21, 2019

Comment from @ShahriarSS in #26590:

@yf225 There are some major problems here. Let me address those and then I can review the PR in detail.

  1. I think that we should have test cases to check the validity of TORCH_CHECKs.
  2. I think that we shouldn't use string for the mode in options. We should use enum classes.
  3. I've had problems with using IntArrayRef as class members. Can we replace it with something else?

Will Feng added 11 commits October 18, 2019 23:17
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
@yf225 yf225 requested review from pbelevich and removed request for ebetica and goldsborough October 21, 2019 20:03
Will Feng added 2 commits October 21, 2019 16:10
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Will Feng added 7 commits October 21, 2019 17:38
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
Add C++ nn::functional pad

This PR adds nn::functional::pad to C++ API

gh-metadata: pytorch pytorch 26601 gh/yf225/1/head
@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in 079b3cc.

@facebook-github-bot facebook-github-bot deleted the gh/yf225/1/head branch October 28, 2019 22:22
thiagocrepaldi pushed a commit to thiagocrepaldi/pytorch that referenced this pull request Feb 4, 2020
Summary: Pull Request resolved: pytorch#26601

Test Plan: Imported from OSS

Differential Revision: D17517468

Pulled By: yf225

fbshipit-source-id: 9ee8b93b88a60f91f2ae78c242f9eaa246b3293c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants