[pytorch] [distributed] [easy] Make distructor virtual for class with virtual function #26504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… virtual function [pytorch] [distributed] Make distructor virtual for class with virtual function Not having virtual distructor may lead to a memory leak. Differential Revision: [D17488876](https://our.internmc.facebook.com/intern/diff/D17488876/) [ghstack-poisoned]
pytorchbot
added
the
oncall: distributed
satgera
added a commit
that referenced
this pull request
Sep 19, 2019
… virtual function [pytorch] [distributed] Make distructor virtual for class with virtual function Not having virtual distructor may lead to a memory leak. Differential Revision: [D17488876](https://our.internmc.facebook.com/intern/diff/D17488876/) ghstack-source-id: 90454880 Pull Request resolved: #26504
pritamdamania87
approved these changes
Sep 20, 2019
Contributor
|
This pull request has been merged in 9ca9018. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[pytorch] [distributed] Make distructor virtual for class with virtual function
Not having virtual distructor may lead to a memory leak.
Differential Revision: D17488876