[pytorch] [distributed] [easy] Corrected variable name and added test #26503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pytorch] [distributed] Corrected variable name and added test Differential Revision: [D17488846](https://our.internmc.facebook.com/intern/diff/D17488846/) [ghstack-poisoned]
pytorchbot
added
the
oncall: distributed
satgera
added a commit
that referenced
this pull request
Sep 19, 2019
[pytorch] [distributed] Corrected variable name and added test Differential Revision: [D17488846](https://our.internmc.facebook.com/intern/diff/D17488846/) ghstack-source-id: 90454793 Pull Request resolved: #26503
This was referenced Sep 19, 2019
Closed
| # TODO: add try-except and destroy _agent in all processes if any fails. | ||
| _agent = ProcessGroupAgent(self_name, group, num_send_recv_threads) | ||
| init_rref_context(_agent) | ||
| elif is_backend_registered(rpc_backend): |
Contributor
There was a problem hiding this comment.
Was this code covered by tests earlier? Why didn't we see some sort of failure since rpc_backend wasn't initialized anywhere?
Contributor
Author
There was a problem hiding this comment.
This wasn't covered by any tests, just added one for invalid backend.
Contributor
There was a problem hiding this comment.
My bad, didn't spot this in last review.
Contributor
Author
There was a problem hiding this comment.
Don't feel bad Shen, it was my diff, I am too used to letting c/c++ compiler catching undeclared variables, getting used to python.
mrshenli
approved these changes
Sep 20, 2019
| # TODO: add try-except and destroy _agent in all processes if any fails. | ||
| _agent = ProcessGroupAgent(self_name, group, num_send_recv_threads) | ||
| init_rref_context(_agent) | ||
| elif is_backend_registered(rpc_backend): |
Contributor
There was a problem hiding this comment.
My bad, didn't spot this in last review.
Contributor
|
This pull request has been merged in b401e9d. |
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26503 [pytorch] [distributed] Corrected variable name and added test ghstack-source-id: 90454793 Test Plan: Made sure pg based UT works. Differential Revision: D17488846 fbshipit-source-id: 6e6cba110a6f61ee1af3d37c5a41c69701de1a8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[pytorch] [distributed] Corrected variable name and added test
Differential Revision: D17488846