[reland] Add NoQEngine to QEngine and refactor the name of set/get qengine #26471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngine Summary: att Test Plan: . Reviewers: pt1quant Subscribers: Tasks: Tags: This reverts commit b1ecf4b. [ghstack-poisoned]
pytorchbot
added
module: internals
This was referenced Sep 19, 2019
dzhulgakov
approved these changes
Sep 19, 2019
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
I'm fine landing it now if the follow up PR changes it to strings on python side
| throw python_error(); | ||
| } | ||
|
|
||
| addQEngine(at::kNoQEngine, "no_qengine", torch_module); |
Collaborator
There was a problem hiding this comment.
sigh, we should really change it to strings, it's getting really polluting to the namespace
Contributor
|
This pull request has been merged in 8f50ea0. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 20, 2019
…6471) Summary: Pull Request resolved: pytorch/pytorch#26471 att Test Plan: . Imported from OSS Differential Revision: D17491215 fbshipit-source-id: 5790aa0113bfdbeeb838f3d1530397606ccaa1e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
att
Test Plan:
.
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
This reverts commit b1ecf4b.
Differential Revision: D17491215