[quant][graph] PyTorch Graph Mode Quantization API #26390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 18, 2019
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 18, 2019
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
requested review from
ZolotukhinM,
dzhulgakov,
gchanan,
raghuramank100 and
soumith
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
reviewed
Sep 19, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good to me overall, and I'm very happy to see that landing! I'll let others to review it as it's a user-facing API, but I left a couple of comments inline.
fmassa
reviewed
Sep 19, 2019
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
more comments everyone? |
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
dzhulgakov
requested changes
Sep 25, 2019
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Reviewers: pt1quant Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 09f0e94. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26390 `quantize_script`: top level API for graph mode quantization Test Plan: there are some known issues, we can enable test after all known issues are fixed. Imported from OSS Differential Revision: D17645132 fbshipit-source-id: 61f261d5607409d493b39a2f4e05ebd017279f6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
quantize_script: top level API for graph mode quantizationTest Plan:
there are some known issues, we can enable test after all known issues are fixed.
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17645132