Refactor Dimname.h API to be nicer #26366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci]
pytorchbot
added
module: internals
This was referenced Sep 17, 2019
Closed
Closed
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci]
zou3519
added a commit
that referenced
this pull request
Sep 17, 2019
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci] ghstack-source-id: dd76957 Pull Request resolved: #26366
nairbv
approved these changes
Sep 18, 2019
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci]
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci]
zou3519
added a commit
that referenced
this pull request
Sep 19, 2019
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci] ghstack-source-id: db151ce Pull Request resolved: #26366
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci]
Closed
zou3519
added a commit
that referenced
this pull request
Sep 19, 2019
Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci] ghstack-source-id: db151ce Pull Request resolved: #26366
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 20, 2019
Summary: Pull Request resolved: pytorch/pytorch#26366 Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci] Differential Revision: D17484757 Pulled By: zou3519 fbshipit-source-id: 21c128e5025e81513e14d34506a7d7744caefdc2
Contributor
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26366 Changes: - `NameType::NORMAL` -> `NameType::BASIC` - `Dimname::is_wildcard` -> `Dimname::isWildcard()` - `Dimname::is_normal` -> `Dimname::isBasic()`. - `at::is_valid_identifier` -> `Dimname::isValidName(string)` - `at::match`, `at::unify` are now methods on `Dimname`. I am adopting CamelCase for struct members of a named tensor related struct. Test Plan: - [namedtensor ci] Differential Revision: D17484757 Pulled By: zou3519 fbshipit-source-id: 21c128e5025e81513e14d34506a7d7744caefdc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Changes:
NameType::NORMAL->NameType::BASICDimname::is_wildcard->Dimname::isWildcard()Dimname::is_normal->Dimname::isBasic().at::is_valid_identifier->Dimname::isValidName(string)at::match,at::unifyare now methods onDimname.I am adopting CamelCase for struct members of a named tensor related
struct.
Test Plan:
Differential Revision: D17484757