Delete tagged names #26365
Closed
Delete tagged names #26365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: - [namedtensor ci]
pytorchbot
added
module: autograd
This was referenced Sep 17, 2019
Closed
Test Plan: - [namedtensor ci]
nairbv
reviewed
Sep 18, 2019
aten/src/ATen/NamedTensorUtils.cpp
Outdated
| } | ||
| auto it = std::find_if(other_names.begin(), other_names.end(), | ||
| [&](const Dimname& candidate) { return name.can_refer_to(candidate); }); | ||
| [&](const Dimname& candidate) { return name == candidate; }); |
Collaborator
There was a problem hiding this comment.
I think you can use std::find() without the lambda?
Contributor
Author
There was a problem hiding this comment.
That's a good point.
Contributor
Author
There was a problem hiding this comment.
Addressed, that made the code a lot nicer. Thank you for catching it!
nairbv
approved these changes
Sep 18, 2019
Test Plan: - [namedtensor ci]
Test Plan: - [namedtensor ci]
Test Plan: - [namedtensor ci]
Closed
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 20, 2019
Summary: Pull Request resolved: pytorch/pytorch#26365 Test Plan: - [namedtensor ci] Differential Revision: D17484759 Pulled By: zou3519 fbshipit-source-id: 44068c1e9d84adf36c5ab5e7006a153b948914d6
Contributor
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26365 Test Plan: - [namedtensor ci] Differential Revision: D17484759 Pulled By: zou3519 fbshipit-source-id: 44068c1e9d84adf36c5ab5e7006a153b948914d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Test Plan:
Differential Revision: D17484759