Kill cpu_zero in THFormal. #26348
Closed
Kill cpu_zero in THFormal. #26348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used in 3 places: baddbmm: irrelevant as we only use the CUDA implmentation addmm: not necessary because we properly resize and then copy to result addmv:: not necessary because we properly resize and then copy to result.
pytorchbot
added
the
module: internals
gchanan
added a commit
that referenced
this pull request
Oct 15, 2019
Related to #26348, which is failing for some reason I haven't tracked down.
gchanan
added a commit
that referenced
this pull request
Oct 15, 2019
Similar to #26348, but only a single change because I don't know why that PR is failing.
gchanan
added a commit
that referenced
this pull request
Oct 15, 2019
Similar to #26348, but only a single change because I don't know why that PR is failing.
gchanan
added a commit
that referenced
this pull request
Oct 16, 2019
Similar to #26348, but only a single change because I don't know why that PR is failing. Differential Revision: [D17932087](https://our.internmc.facebook.com/intern/diff/D17932087)
gchanan
added a commit
that referenced
this pull request
Oct 16, 2019
Similar to #26348, but only a single change because I don't know why that PR is failing. Differential Revision: [D17931058](https://our.internmc.facebook.com/intern/diff/D17931058)
gchanan
added a commit
that referenced
this pull request
Oct 16, 2019
Related to #26348, which is failing for some reason I haven't tracked down. Differential Revision: [D17930834](https://our.internmc.facebook.com/intern/diff/D17930834)
Contributor
Author
|
theory: addmv shows up as failing because it doesn't guard copying the tensor to the result (in the out-of-place version by checking that |
Contributor
Author
|
Yep, the above seems to be correct, all the other cases check for beta before doing the copy. |
gchanan
added a commit
that referenced
this pull request
Oct 16, 2019
Similar to #26348, but only a single change because I don't know why that PR is failing. Differential Revision: [D17932087](https://our.internmc.facebook.com/intern/diff/D17932087)
Contributor
Author
|
Superseded by #27980. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It's only used in 3 places:
baddbmm: irrelevant as we only use the CUDA implmentation
addmm: not necessary because we properly resize and then copy to result
addmv:: not necessary because we properly resize and then copy to result.