Rebase CircleCI to master if it is gcc5_4 #26321
Conversation
houseroad
force-pushed
the
add_bc_ci
branch
5 times, most recently
from
baf4172 to
b18a4ff
Compare
houseroad
force-pushed
the
add_bc_ci
branch
from
08d1f0e to
97b2c5d
Compare
houseroad
changed the title
| docker pull ${DOCKER_IMAGE} >/dev/null | ||
| export id=$(docker run -t -d -w /var/lib/jenkins ${DOCKER_IMAGE}) | ||
| # Rebase to master only if in xenial_py3_6_gcc5_4 case |
There was a problem hiding this comment.
Better to put this chunk of code into a "step"?
There was a problem hiding this comment.
Sure, if that is preferred, I can turn it into a step.
| ("gcc", [ | ||
| ("4.8", [X("3.6")]), | ||
| ("5.4", [ | ||
| ("5.4", [ # All this subtree rebases to master and then build |
There was a problem hiding this comment.
Better to add compat to the name of jobs that run the backward compatibility checks? (and then configure the generator script to add a step to merge with master for all compat jobs)
There was a problem hiding this comment.
Yes. I will add bc to the name of test phase, see #26329
This is only for build. Want to share the build stage with some other tests.
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
okey dokey, although this code is a lot more complicated than I expected lol
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in b63f8ef. |
6 participants
This is the first step of adding CI for bc breaking changes detection of function shcemas.