C++ API parity: at::Tensor::detach #26251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbelevich
requested review from
ebetica,
goldsborough and
yf225
as code owners
This was referenced Sep 15, 2019
Closed
yf225
approved these changes
Sep 17, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
Thanks a lot for the thorough tests @pbelevich !
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
pbelevich
added a commit
to pbelevich/pytorch
that referenced
this pull request
Sep 20, 2019
ghstack-source-id: 072dea0 Pull Request resolved: pytorch#26251
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
This was referenced Sep 20, 2019
Differential Revision: [D17427578](https://our.internmc.facebook.com/intern/diff/D17427578) [ghstack-poisoned]
14 tasks
Contributor
|
@pbelevich merged this pull request in 6b25562. |
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26251 Test Plan: Imported from OSS Differential Revision: D17427578 Pulled By: pbelevich fbshipit-source-id: c3d23a8c2da4148b86e7760ba5023eb38f7835af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17427578