Add TEST_NAMEDTENSOR flag to namedtensor ci #25948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, test/test_namedtensor.py is skipped if pytorch was not compiled with BUILD_NAMEDTENSOR. Now, we skip test/test_namedtensor.py if pytorch was not compiled with BUILD_NAMEDTENSOR or if TEST_NAMEDTENSOR is not set. This is done in preparation for turning on BUILD_NAMEDTENSOR=1 permanently; at that point we will use TEST_NAMEDTENSOR to differentiate between the named tensor ci and the regular ci. Test Plan: - [namedtensor ci] (and check that the named tensor tests are actually running).
This was referenced Sep 10, 2019
nairbv
approved these changes
Sep 11, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously, test/test_namedtensor.py is skipped if pytorch was not
compiled with BUILD_NAMEDTENSOR. Now, we skip test/test_namedtensor.py
if pytorch was not compiled with BUILD_NAMEDTENSOR or if
TEST_NAMEDTENSOR is not set.
This is done in preparation for turning on BUILD_NAMEDTENSOR=1 permanently;
at that point we will use TEST_NAMEDTENSOR to differentiate between the
named tensor ci and the regular ci.
Test Plan:
running).
Pull Request resolved: #25948
Differential Revision: D17300132