[pytorch][mobile] disable backward function codegen if disable_autograd is set #25817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad is set Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs
pytorchbot
added
the
module: internals
This was referenced Sep 7, 2019
Closed
Contributor
|
I'm going to leave this one to @gchanan, as this change is by his request. |
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
This was referenced Sep 10, 2019
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
This was referenced Sep 10, 2019
ljk53
added a commit
that referenced
this pull request
Sep 10, 2019
…n codegen if disable_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
ljk53
added a commit
that referenced
this pull request
Sep 11, 2019
…n codegen if disable_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
This was referenced Sep 11, 2019
Contributor
Author
|
The impact on compressed DSO size: Before: After: |
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
ljk53
added a commit
that referenced
this pull request
Sep 11, 2019
…n codegen if disable_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
…able_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
ljk53
added a commit
that referenced
this pull request
Sep 11, 2019
…n codegen if disable_autograd is set" Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs Pull Request resolved: #25817 Differential Revision: [D17247235](https://our.internmc.facebook.com/intern/diff/D17247235)
Contributor
|
so now we have access to AsStridedBackward? That seems good, but do we need to do this in codegen, instead of arranging the files in some way to achieve the same thing more obviously? |
Contributor
Author
|
This PR is mainly to shrink static library size as most code removed by this PR will be removed by linker automatically for dynamic library. As we are ok with the iOS static library build size for now so I think we can abandon this change to avoid adding complexity to the system. |
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
…ad is set Summary: As discussed on PR #25697 - to remove autograd/functions.* without using intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp. Test Plan: - builds and runs with stacked diffs ghstack-source-id: 3a1b5ee Pull Request resolved: pytorch/pytorch#25817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
As discussed on PR #25697 - to remove autograd/functions.* without using
intrusive #if/#else we need whitelist "AsStridedBackward" used by variable.cpp.
Test Plan:
Pull Request resolved: #25817
Differential Revision: D17247235