Kill declared_type and ignore_check from THFormal. #25655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't used anymore.
pytorchbot
added
the
module: internals
This was referenced Sep 4, 2019
zou3519
reviewed
Sep 4, 2019
| return unique | ||
|
|
||
|
|
||
| def sort_by_number_of_options(declaration, reverse=True): |
Contributor
There was a problem hiding this comment.
nit: rename this to sort_by_number_of_args or something similar. options doesn't mean anything here anymore
zou3519
approved these changes
Sep 4, 2019
They aren't used anymore.
They aren't used anymore.
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
This was referenced Sep 5, 2019
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
They aren't used anymore. Differential Revision: [D17188631](https://our.internmc.facebook.com/intern/diff/D17188631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
They aren't used anymore.
Differential Revision: D17188631