[refactor] Remove unnecessary checks in InsertQuantDeQuantImpl #25370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Removes some checking code that is copied from insert_observers pass Test Plan: python test/test_jit.py 'TestJit.test_insert_quant_dequant' Reviewers: pt1quant Subscribers: Tasks: Tags:
This was referenced Aug 29, 2019
ZolotukhinM
reviewed
Aug 29, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
I think we can clean it up more, please see inline.
…Impl" Summary: Removes some checking code that is copied from insert_observers pass Test Plan: python test/test_jit.py 'TestJit.test_insert_quant_dequant' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106633](https://our.internmc.facebook.com/intern/diff/D17106633)
…Impl" Summary: Removes some checking code that is copied from insert_observers pass Test Plan: python test/test_jit.py 'TestJit.test_insert_quant_dequant' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106633](https://our.internmc.facebook.com/intern/diff/D17106633)
ZolotukhinM
approved these changes
Aug 29, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Yep, looks better now, thank you!
…Impl" Summary: Removes some checking code that is copied from insert_observers pass Test Plan: python test/test_jit.py 'TestJit.test_insert_quant_dequant' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106633](https://our.internmc.facebook.com/intern/diff/D17106633)
Contributor
|
This pull request has been merged in 629a2b3. |
This was referenced Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Removes some checking code that is copied from insert_observers pass
Test Plan:
python test/test_jit.py 'TestJit.test_insert_quant_dequant'
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17106633