[quant][graphmode] Skip inserting observers for Tensors inside fused op #25281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
This was referenced Aug 28, 2019
jerryzh168
added a commit
that referenced
this pull request
Aug 28, 2019
Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 9492d9f Pull Request resolved: #25281
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
jerryzh168
added a commit
that referenced
this pull request
Aug 28, 2019
Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags: ghstack-source-id: 7a7663d Pull Request resolved: #25281
ZolotukhinM
approved these changes
Aug 28, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Overall looks good! Please find a couple of remarks inline.
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags:
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106037](https://our.internmc.facebook.com/intern/diff/D17106037)
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106037](https://our.internmc.facebook.com/intern/diff/D17106037)
nishantpdce
reviewed
Aug 29, 2019
ZolotukhinM
reviewed
Aug 29, 2019
…side fused op" Summary: We want to skip inserting observers for the Tensors that's between the two ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern, but new patterns can be easily added in the future. Test Plan: python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values' Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17106037](https://our.internmc.facebook.com/intern/diff/D17106037)
Contributor
|
This pull request has been merged in f495a3a. |
This was referenced Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
We want to skip inserting observers for the Tensors that's between the two
ops that will be fused, e.g. Conv -> ReLU, this PR just added this pattern,
but new patterns can be easily added in the future.
Test Plan:
python test test/test_jit.py -- 'TestJit.test_insert_observers_skip_values'
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17106037