[graphmode] insert_observers use qconfig_dict #25069
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
pytorchbot
added
oncall: jit
This was referenced Aug 23, 2019
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Closed
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags:
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
ZolotukhinM
suggested changes
Aug 27, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Overall looks nice, but some places might benefit from some refactoring. Without it it's difficult to review the logic, so I'll wait for you to address that before approving.
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
ZolotukhinM
approved these changes
Aug 28, 2019
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good, but please run clang-format before landing.
Contributor
Author
|
test failure is fixed in next PR |
Contributor
Author
planning to run clang-format in one PR after the stack lands |
Mm, that's bad, if the tests are failing, we shouldn't land. If |
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Contributor
Author
I think the fix is actually just the next PR :), I'll land the stack directly so people won't see the breakage |
There will still be a broken commit in git. If someone starts working of that commit, they'll have to deal with the breakages. Committing broken stuff is a bad practice, please don't do it. |
Contributor
Author
|
sure, I can turn off the test and turn it back on in next pr |
Summary: This PR changes the API of insert_observers to use qconfig_dict, full functionality support will come in later PRs Test Plan: ``` python test/test_quantizer.py python test/test_jit.py ``` Reviewers: pt1quant Subscribers: Tasks: Tags: Differential Revision: [D17001135](https://our.internmc.facebook.com/intern/diff/D17001135)
Contributor
|
This pull request has been merged in 11b4d57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This PR changes the API of insert_observers to use qconfig_dict,
full functionality support will come in later PRs
Test Plan:
Reviewers:
pt1quant
Subscribers:
Tasks:
Tags:
Differential Revision: D17001135