[quant] Adding Scalar add/mul. #24447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This should be landed ONLY after #24259
pytorchbot
added
module: nn
This was referenced Aug 15, 2019
z-a-f
requested review from
dzhulgakov,
jamesr66a,
jerry39213gh,
jerryzh168 and
lly-zero-one
and removed request for
jerry39213gh
Contributor
lly-zero-one
left a comment
lly-zero-one
left a comment
There was a problem hiding this comment.
LGTM, can you also add a test to cover the add/mul scalar?
Note: This should be landed ONLY after #24259 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Note: This should be landed ONLY after #24259 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Author
The numerical tests are performed on the kernels. The API test is covered by the |
Note: This should be landed ONLY after #24259 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Note: This should be landed ONLY after #24259 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
added 2 commits
August 20, 2019 17:57
Note: This should be landed ONLY after #24259 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Note: This should be landed ONLY after #24259 Pull Request resolved: #24447 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Note: This should be landed ONLY after #24259 Pull Request resolved: #24447 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
z-a-f
pushed a commit
that referenced
this pull request
Aug 23, 2019
Note: This should be landed ONLY after #24259 Pull Request resolved: #24447 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
Note: This should be landed ONLY after #24259 Pull Request resolved: #24447 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
z-a-f
pushed a commit
that referenced
this pull request
Aug 25, 2019
Note: This should be landed ONLY after #24259 Pull Request resolved: #24447 Differential Revision: [D16846006](https://our.internmc.facebook.com/intern/diff/D16846006)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 26, 2019
Summary: Pull Request resolved: pytorch/pytorch#24447 Note: This should be landed ONLY after #24259 Pull Request resolved: pytorch/pytorch#24447 Differential Revision: D16846006 Test Plan: Imported from OSS Pulled By: zafartahirov fbshipit-source-id: 458fd65279d98cb177ef206240d24dfcbc8d1c1b
Contributor
|
@zafartahirov merged this pull request in 3b3261c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Note: This should be landed ONLY after #24259
Pull Request resolved: #24447
Differential Revision: D16846006