Skip to content

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Aug 13, 2019

Stack from ghstack:

benchmark code. not meant for review or landing.

Differential Revision: D16776891

@pytorchbot pytorchbot added module: internals Related to internal abstractions in c10 and ATen module: operators labels Aug 13, 2019
smessmer added a commit that referenced this pull request Aug 13, 2019
benchmark code. not meant for review or landing.

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)

ghstack-source-id: 88215847
Pull Request resolved: #24253
smessmer added a commit that referenced this pull request Aug 14, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 88253728

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
@ezyang
Copy link
Contributor

ezyang commented Aug 26, 2019

IMO, we should land this code, or something like it. It is very helpful to have a fixed executable or simulated workload with no actual kernel entries that different people can use to run benchmarks. Also, this commit seems to be missing the actual benchmark program itself?

smessmer added a commit that referenced this pull request Aug 31, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 89347247

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
@ezyang
Copy link
Contributor

ezyang commented Aug 31, 2019

Can we make it so these functions don't show up in torch.blah namespace?

smessmer added a commit that referenced this pull request Sep 1, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 89352002

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 1, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 89357686

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 4, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 89485011

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 12, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 89992900

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 12, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 90024978

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 13, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 90050154

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 13, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 90060746

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 13, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 90101709

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
smessmer added a commit that referenced this pull request Sep 15, 2019
Pull Request resolved: #24253

benchmark code. not meant for review or landing.
ghstack-source-id: 90130453

Differential Revision: [D16776891](https://our.internmc.facebook.com/intern/diff/D16776891/)
@smessmer smessmer closed this Sep 15, 2019
@facebook-github-bot facebook-github-bot deleted the gh/smessmer/25/head branch October 28, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: internals Related to internal abstractions in c10 and ATen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants