Skip to content

Fix build failure on OSX #23998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrshenli wants to merge 1 commit into from
Closed

Fix build failure on OSX #23998

mrshenli wants to merge 1 commit into from

Conversation

@mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Aug 8, 2019 •
edited
Loading

#23228 caused build failure on OSX, because rpc.h is included as long as USE_DISTRIBUTED=1, but rpc/init.cpp (and others) is only included when NOT APPLE. So, it cannot find python_functions defined in init.cpp on MacOS. This PR attempt to fix it by wrapping rpc.h with USE_C10D, which is only set when NOT APPLE.

I tried this fix locally and it works.

@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label Aug 8, 2019
facebook-github-bot
facebook-github-bot reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrshenli mrshenli mentioned this pull request Aug 8, 2019
Closed
@mrshenli
Copy link
Contributor Author

mrshenli commented Aug 8, 2019

import torch
dyld: lazy symbol binding failed: Symbol not found: __ZN5torch11distributed3rpc16python_functionsEv
Referenced from: /Users/ashkanaliabadi/Development/pytorch/torch/lib/libtorch_python.dylib
Expected in: flat namespace
dyld: Symbol not found: __ZN5torch11distributed3rpc16python_functionsEv
Referenced from: /Users/ashkanaliabadi/Development/pytorch/torch/lib/libtorch_python.dylib
Expected in: flat namespace
Abort trap: 6

Hi @yf225, OSX hits the above error when trying to import torch after build (my fault). Do you why this is not caught by CI?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 8, 2019

@mrshenli merged this pull request in 02d3c30.

@yf225
Copy link
Contributor

yf225 commented Aug 8, 2019

@mrshenli I suspect that it's because we are not running OSX tests in per-PR CI, but the import error should show up on master pytorch_macos_10_13_py3_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@aazzolini aazzolini Awaiting requested review from aazzolini

@pietern pietern Awaiting requested review from pietern

+1 more reviewer

@pritamdamania87 pritamdamania87 pritamdamania87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: internals Related to internal abstractions in c10 and ATen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mrshenli @facebook-github-bot @yf225 @pritamdamania87 @pytorchbot @mruberry