Allow TensorMethods.h to include Dispatcher.h (alternative) #23888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
pytorchbot
added
module: build
This was referenced Aug 6, 2019
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This was referenced Aug 6, 2019
Closed
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
dzhulgakov
reviewed
Aug 7, 2019
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
many of the builds are broken (though I didn't looks why)
otherwise looks legit
Contributor
|
deferring to @dzhulgakov |
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
Collaborator
|
Looks good. There's some obscure error on windows build: |
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
Closed
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
smessmer
added a commit
that referenced
this pull request
Aug 23, 2019
Pull Request resolved: #23888 This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. ghstack-source-id: 88912399 Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
smessmer
added a commit
that referenced
this pull request
Aug 29, 2019
Pull Request resolved: #23888 This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. ghstack-source-id: 89202221 Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
smessmer
added a commit
that referenced
this pull request
Aug 31, 2019
Pull Request resolved: #23888 This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. ghstack-source-id: 89345742 Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
This is an alternative to #23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. Differential Revision: [D16673569](https://our.internmc.facebook.com/intern/diff/D16673569/)
Contributor
Author
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 4, 2019
Summary: Pull Request resolved: pytorch/pytorch#23888 This is an alternative to pytorch/pytorch#23684. Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed. ghstack-source-id: 89357687 Test Plan: waitforsandcastle Differential Revision: D16673569 fbshipit-source-id: fa1d92809b05de7910a8c2dc2f55abe071ca63bf
Contributor
|
This pull request has been merged in 7913476. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is an alternative to #23684.
Instead of splitting a bunch of headers into declaration and definition, we change tensor includes to only include the tensor declaration when the tensor definition isn't needed.
Differential Revision: D16673569