Updated docs and added deprecation warnings to acknowledge a bool ten… #23811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
vishwakftw
reviewed
Aug 5, 2019
| for (const auto & index : indices) { | ||
| if (index.scalar_type() == kByte || index.scalar_type() == kBool) { | ||
| if (index.scalar_type() == kByte) { | ||
| AT_WARN("indexing with dtype torch.uint8 is now deprecated," \ |
Contributor
There was a problem hiding this comment.
Wouldn’t it be appropriate to use TORCH_WARN instead of the deprecated AT_WARN?
Contributor
Author
There was a problem hiding this comment.
Its a cherry-pick from the master branch. If this has to be fixed, it should be done there first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #22261
ghimport-source-id: 1611d62
Test Plan: Imported from OSS
Differential Revision: D16005990
Pulled By: izdeby
fbshipit-source-id: 2413824aa75a0755719e4df11acd21e6607e5a85