Open up AliasAnalysisKind for any ops #23810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D15996322](https://our.internmc.facebook.com/intern/diff/D15996322/)
pytorchbot
added
oncall: jit
Contributor
Author
|
this is a new export of #22239 which got deleted by a branch-pruning script |
This was referenced Aug 5, 2019
Closed
Contributor
|
This pull request has been merged in 3ad9dbf. |
Member
|
This PR broke master, I am reverting |
Contributor
Author
|
thanks for the fast reaction @suo |
smessmer
added a commit
that referenced
this pull request
Aug 5, 2019
Re-expot of reverted PR #23810 with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
smessmer
added a commit
that referenced
this pull request
Aug 5, 2019
Re-expot of reverted PR #23810 with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/) ghstack-source-id: 87754063 Pull Request resolved: #23834
smessmer
added a commit
that referenced
this pull request
Aug 6, 2019
Re-expot of reverted PR #23810 with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
smessmer
added a commit
that referenced
this pull request
Aug 8, 2019
Re-expot of reverted PR #22239 (or actually #23810) with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
smessmer
added a commit
that referenced
this pull request
Aug 9, 2019
Re-expot of reverted PR #22239 (or actually #23810) with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. Differential Revision: [D16657239](https://our.internmc.facebook.com/intern/diff/D16657239/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2019
Summary: Pull Request resolved: #23834 Re-expot of reverted PR #23810 with the bug fixed A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that our existing aten:: and prim:: ops set the correct AliasAnalysisKind. However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly, we can remove these assertions. ghstack-source-id: 88050427 Differential Revision: D16657239 fbshipit-source-id: 8a7606da8e9bd961bf47e3e1587b622a9c247ec6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
A previous diff removed the special casing for aten:: and prim:: ops in alias analysis and implements alias analysis purely
based on the AliasAnalysisKind. To be sure it doesn't break our existing code base, it added asserts that make sure that
our existing aten:: and prim:: ops set the correct AliasAnalysisKind.
However, we don't need that restriction for future ops. Since we are now certain all existing cases are set up correctly,
we can remove these assertions.
Differential Revision: D15996322