Adam implementation minor fix #23737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
approved these changes
Aug 2, 2019
Contributor
|
Thanks for the fix @farhadrgh! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ssnl
reviewed
Aug 2, 2019
torch/csrc/api/src/optim/adam.cpp
Outdated
| .addcmul_(p.grad(), p.grad(), 1 - options.beta2_); | ||
|
|
||
| Tensor denom = exp_average_sq; | ||
| Tensor denom = exp_average_sq / bias_correction2; |
Collaborator
There was a problem hiding this comment.
arguably this should be in an else block to avoid computation when options.amsgrad_
vincentqb
reviewed
Aug 2, 2019
vincentqb
suggested changes
Aug 2, 2019
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
Please confirm that line 43 is indeed correct.
vincentqb
added
the
triaged
vincentqb
approved these changes
Aug 5, 2019
Contributor
vincentqb
left a comment
vincentqb
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@vincentqb merged this pull request in ab15d38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in accordance with #22628
I had submitted the PR for
adam.pyandadamw.pybut had forgotten about theadam.cpp.