Fixed size arrays #23695
Closed
Fixed size arrays #23695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
pytorchbot
added
module: internals
This was referenced Aug 1, 2019
smessmer
added a commit
that referenced
this pull request
Aug 2, 2019
Pull Request resolved: #23695 ghstack-source-id: 87604034 Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
smessmer
added a commit
that referenced
this pull request
Aug 2, 2019
Pull Request resolved: #23695 ghstack-source-id: 87660048 Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
smessmer
added a commit
that referenced
this pull request
Aug 5, 2019
Pull Request resolved: #23695 ghstack-source-id: 87744924 Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
smessmer
added a commit
that referenced
this pull request
Aug 6, 2019
Pull Request resolved: #23695 ghstack-source-id: 87767190 Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
Closed
Closed
Fix JIT schema inference for fixed sized arrays like `int[3]` and move corresponding ops to the c10 dispatcher. Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/)
ezyang
approved these changes
Sep 16, 2019
Fix JIT schema inference for fixed sized arrays like `int[3]` and move corresponding ops to the c10 dispatcher. Differential Revision: [D16611697](https://our.internmc.facebook.com/intern/diff/D16611697/) [ghstack-poisoned]
This was referenced Sep 17, 2019
zdevito
approved these changes
Sep 17, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Didn't look too closely but seems fine to me.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 17, 2019
Summary: Pull Request resolved: pytorch/pytorch#23695 Fix JIT schema inference for fixed sized arrays like `int[3]` and move corresponding ops to the c10 dispatcher. ghstack-source-id: 90222271 Test Plan: waitforsandcastle Differential Revision: D16611697 fbshipit-source-id: b20a479ffcd8fe8421b11bb259802745923e3b0d
Contributor
|
This pull request has been merged in 2470031. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix JIT schema inference for fixed sized arrays like
int[3]and move corresponding ops to the c10 dispatcher.Differential Revision: D16611697