[v1.2.0] Allowing batching for det/logdet/slogdet operations (#22909) #23634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: - Add batching for det / logdet / slogdet operations - Update derivative computation to support batched inputs (and consequently batched outputs) - Update docs Pull Request resolved: pytorch#22909 Test Plan: - Add a `test_det_logdet_slogdet_batched` method in `test_torch.py` to test `torch.det`, `torch.logdet` and `torch.slogdet` on batched inputs. This relies on the correctness of `torch.det` on single matrices (tested by `test_det_logdet_slogdet`). A port of this test is added to `test_cuda.py` - Add autograd tests for batched inputs Differential Revision: D16580988 Pulled By: ezyang fbshipit-source-id: b76c87212fbe621f42a847e3b809b5e60cfcdb7a
pytorchbot
added
oncall: jit
Contributor
Author
|
ASAN test failure seems to be unrelated. |
vishwakftw
changed the title
ssnl
approved these changes
Aug 1, 2019
Contributor
Author
|
@soumith could this be merged in v1.2.0? Edit: sorry I didn’t notice the status footer in the release tracker issue under each comment, I was just afraid this might be forgotten |
Contributor
|
cc @fritzo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Pull Request resolved: Allowing batching for det/logdet/slogdet operations #22909
Test Plan:
test_det_logdet_slogdet_batchedmethod intest_torch.pyto testtorch.det,torch.logdetandtorch.slogdeton batched inputs. This relies on the correctness oftorch.deton single matrices (tested bytest_det_logdet_slogdet). A port of this test is added totest_cuda.pyDifferential Revision: D16580988
Pulled By: ezyang
fbshipit-source-id: b76c87212fbe621f42a847e3b809b5e60cfcdb7a