fix gemm call for CUDABlas for THCUNN conv, #23545 #23552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cuda
soumith
reviewed
Jul 30, 2019
test/test_nn.py
Outdated
|
|
||
| @unittest.skipIf(not TEST_CUDA, 'CUDA not available') | ||
| def test_ConvTranspose2d_half_cublas_gemm(self): | ||
| inputs = torch.randn(1, 1, 16, 16, device='cuda', dtype=torch.half) |
Contributor
There was a problem hiding this comment.
you can also force CuDNN to be off (for future safety) using the context manager we have available (i think it's called with torch.backends.cudnn something something
Collaborator
Author
There was a problem hiding this comment.
Thanks! I've added the context manager.
soumith
approved these changes
Jul 30, 2019
soumith
approved these changes
Jul 30, 2019
Collaborator
|
@pytorchbot merge this please also @soumith , this probably wants to be in 1.2 too i suppose? |
pytorchbot
added
the
merge-this-please
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2019
Summary: * Swapped `CUBLAS_OP_N` for `'n'` * added a test This PR should fix pytorch/pytorch#23545. Thanks at AlphabetMan for reporting the initial issue reported in [the forum](https://discuss.pytorch.org/t/cuda-10-1-error-using-transposeconv2d-with-output-padding-1/51414?u=ptrblck) as well as ngimel for the guidance. Pull Request resolved: pytorch/pytorch#23552 Differential Revision: D16580986 Pulled By: ezyang fbshipit-source-id: abc0bce1e84d9c9d96d44ae0296951725adc8424
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUBLAS_OP_Nfor'n'This PR should fix #23545.
Thanks at AlphabetMan for reporting the initial issue reported in the forum as well as @ngimel for the guidance.