Unboxed kernels in c10 #23447
Closed
Unboxed kernels in c10 #23447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
pytorchbot
added
the
module: internals
smessmer
added a commit
that referenced
this pull request
Jul 26, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/) ghstack-source-id: 87262377 Pull Request resolved: #23447
dzhulgakov
reviewed
Jul 29, 2019
| } | ||
|
|
||
| template<class Result, class... Args> | ||
| inline Result callOpUnboxed(const c10::OperatorHandle& op, c10::TensorTypeId dispatchKey, Args... args) { |
Collaborator
There was a problem hiding this comment.
I though the whole point of unboxed call was to figure out the dispatch key from arguments. Do you think it's doable with template magic to collect keys of arguemnts (I recall you had this code somewhere). If not - we can codegen it
Contributor
Author
There was a problem hiding this comment.
This is planned but a future PR. There's a mismatch between c10 and aten currently because c10 chooses "the first tensor argument" to dispatch on while aten looks for "the tensor argument named 'self'". The plan is to add this 'self' functionality to c10 and then use it.
dzhulgakov
reviewed
Jul 30, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
smessmer
added a commit
that referenced
this pull request
Jul 31, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Pull Request resolved: #23447 ghstack-source-id: 87461228 Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
smessmer
added a commit
that referenced
this pull request
Aug 1, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Pull Request resolved: #23447 ghstack-source-id: 87539686 Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
dzhulgakov
approved these changes
Aug 1, 2019
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
Stamping it as a standalone change. But it'd be nice to see how it'd connect end-to-end (including boxing/unboxing and figuring out the dispatch keys) and what's the plan going forward
This was referenced Aug 1, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
This was referenced Aug 1, 2019
Closed
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
This was referenced Aug 5, 2019
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Differential Revision: [D16521939](https://our.internmc.facebook.com/intern/diff/D16521939/)
Contributor
|
This pull request has been merged in 9dbee5f. |
25 tasks
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 9, 2019
Summary: The c10 dispatcher now also stores a `void*` pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature. It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch. Pull Request resolved: pytorch/pytorch#23447 ghstack-source-id: 88050435 Differential Revision: D16521939 fbshipit-source-id: 7e570df5a721defc677c3cc91758651dbe06ce1c
yf225
pushed a commit
to yf225/pytorch
that referenced
this pull request
Aug 11, 2019
This reverts commit 9dbee5f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The c10 dispatcher now also stores a
void*pointer to the unboxed kernel function and this kernel function can be called if the call site knows the exact kernel signature.It is not clear if this API will survive in the long term, but in the short term this allows an easier migration from ATen to c10 and is supposed to replace ATenDispatch.
Differential Revision: D16521939