Skip to content

Fix distributions.Categorical.sample bug from .view() #23328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fritzo wants to merge 1 commit into from
Closed

Fix distributions.Categorical.sample bug from .view() #23328

fritzo wants to merge 1 commit into from

Conversation

@fritzo
Copy link
Collaborator

@fritzo fritzo commented Jul 24, 2019

This modernizes distributions code by replacing a few uses of .contiguous().view() with .reshape(), fixing a sample bug in the Categorical distribution.

The bug is exercised by the following test:

batch_shape = (1, 2, 1, 3, 1)
sample_shape = (4,)
cardinality = 2
logits = torch.randn(batch_shape + (cardinality,))
dist.Categorical(logits=logits).sample(sample_shape)
# RuntimeError: invalid argument 2: view size is not compatible with
#   input tensor's size and stride (at least one dimension spans across
#   two contiguous subspaces). Call .contiguous() before .view().
#   at ../aten/src/TH/generic/THTensor.cpp:203

I have verified this works locally, but I have not added this as a regression test because it is unlikely to regress (the code is now simpler).

@fritzo fritzo added the module: distributions Related to torch.distributions label Jul 24, 2019
@fritzo fritzo requested a review from neerajprad July 24, 2019 19:58
@fritzo fritzo mentioned this pull request Jul 24, 2019
Merged
neerajprad
neerajprad approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@neerajprad neerajprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and simplifying this!

@apaszke
Copy link
Contributor

apaszke commented Jul 26, 2019

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Jul 26, 2019
facebook-github-bot
facebook-github-bot reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 29, 2019

@colesbury merged this pull request in 06762b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+2 more reviewers

@neerajprad neerajprad neerajprad approved these changes

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please Merged module: distributions Related to torch.distributions open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fritzo @apaszke @facebook-github-bot @neerajprad @ezyang @pytorchbot @mruberry