[JIT] fix specialized list from dict keys #23267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
reviewed
Jul 23, 2019
| template <unsigned int Index> | ||
| c10::impl::GenericList makeGenericListForDictKeysOrValues( | ||
| const std::vector<std::pair<IValue, IValue>>& order) { | ||
| auto values = c10::impl::GenericList(c10::impl::deprecatedUntypedList()); |
Contributor
There was a problem hiding this comment.
Is it possible to do c10::List<IValue> so we don't have to have a separate copy of this function for GenericLists?
Contributor
Author
There was a problem hiding this comment.
that doesn't compile. And you can't do partial template specialization so that you are only passing in the Index in
driazati
reviewed
Jul 23, 2019
test/test_jit.py
Outdated
| def specialized_list(): | ||
| return {1: 1, 2: 2}.keys() | ||
|
|
||
| self.assertTrue(set(specialized_list()) == set([1, 2])) |
Contributor
There was a problem hiding this comment.
This would have passed with deprecatedUntypedList before, how does it test the change?
Contributor
Author
There was a problem hiding this comment.
now it is testing an op with a specialized list. i don't know what deprecatedUntypedList is
Contributor
Author
There was a problem hiding this comment.
okay added op that uses specialized list
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
driazati
approved these changes
Jul 23, 2019
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2019
Summary: Add `sorted` keyword to JIT for lists and dicts. This desugars to a list copy and a call to `list.sort()`. Since we don't have interfaces yet I implement it in terms of `list.sort()`. When we do we can re-visit implementing this op in a different manner. The test fails bc of a fix to specialized lists which is landing here: #23267 Ignore the first commit because it is formatting, plz use clang_format ppl :'( Pull Request resolved: #23274 Differential Revision: D16527323 Pulled By: eellison fbshipit-source-id: aed8faef23cb790b9af036cd6c1b9b1d7066345d
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 27, 2019
Summary: Add `sorted` keyword to JIT for lists and dicts. This desugars to a list copy and a call to `list.sort()`. Since we don't have interfaces yet I implement it in terms of `list.sort()`. When we do we can re-visit implementing this op in a different manner. The test fails bc of a fix to specialized lists which is landing here: pytorch/pytorch#23267 Ignore the first commit because it is formatting, plz use clang_format ppl :'( Pull Request resolved: pytorch/pytorch#23274 Differential Revision: D16527323 Pulled By: eellison fbshipit-source-id: aed8faef23cb790b9af036cd6c1b9b1d7066345d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we weren't specializing the list returned from
dict.keys()