Skip to content

Conversation

@zhangguanheng66
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 commented Jul 23, 2019

Re-land #23030

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: multiprocessing Related to torch.multiprocessing labels Jul 23, 2019
@zhangguanheng66 zhangguanheng66 changed the title [NOT TO LAND] Cuda fork err [NOT TO LAND] Re-land "Fix error message for a wrong fork CUDA" Jul 23, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangguanheng66 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhangguanheng66 zhangguanheng66 changed the title [NOT TO LAND] Re-land "Fix error message for a wrong fork CUDA" Re-land "Fix error message for a wrong fork CUDA" Jul 23, 2019
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bring back the test!

@zhangguanheng66 zhangguanheng66 requested a review from ezyang July 23, 2019 21:24
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under assumption that we tested with Python 2 CUDA. A local test or modifying CI to temporarily test it is sufficient.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangguanheng66 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zhangguanheng66 merged this pull request in aa660b8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: multiprocessing Related to torch.multiprocessing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants