Revert "Improve performance of advanced indexing backward (#20557)" #23102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: autograd
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 20, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 20, 2019
Summary: Fixes pytorch/pytorch#22843, also adds test from pytorch/pytorch#23102 Pull Request resolved: pytorch/pytorch#23123 Differential Revision: D16402422 Pulled By: soumith fbshipit-source-id: aa7a79159ed947be03ce3725ec8abcf5246a60bf
Contributor
Author
|
Obsoleted by #23123. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This reverts commit ad971a3.
Fixes #22843. The revert also adds a test for this case.
Hopefully we can find a real fix for this and don't have to revert
the commit, but I'm posting this PR in case we cannot find a fix
in time for release.