Skip to content

Remove cuda free mutex #23040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeffdaily wants to merge 5 commits into from
Closed

Remove cuda free mutex #23040

jeffdaily wants to merge 5 commits into from

Conversation

@jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Jul 18, 2019

Revision of #22173 to address CI failure after merging.

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general oncall: distributed Add this issue/PR to distributed oncall triage queue module: nccl Problems related to nccl support module: pybind Related to our Python bindings / interactions with other Python libraries labels Jul 18, 2019
@jeffdaily jeffdaily mentioned this pull request Jul 18, 2019
Closed
mrshenli
mrshenli approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffdaily!!

Pre-approving as this is already reviewed in #22173, which misses noexcept(false) in AutoNcclGroup destructor. Let's wait for the CI to complete before landing.

facebook-github-bot
facebook-github-bot reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrshenli
Copy link
Contributor

mrshenli commented Jul 19, 2019 •
edited
Loading

@pytorchbot retest this please

@mrshenli
Copy link
Contributor

mrshenli commented Jul 19, 2019

Hi @yf225 , I tried the failed ROCM CI test ([1] [2]) twice, but the following tests keep failing. I think it is irrelevant to this PR, as the same error also occurs in other PR (e.g.). Do you know if anyone is working on the fix? I would like to make sure all tests pass before landing this.

test_conv_backcompat (__main__.TestNN) ... ERROR
test_no_grad (__main__.TestNN) ... ERROR
test_noncontig_conv_grad_cuda (__main__.TestNN) ... ERROR

@pietern
Copy link
Contributor

pietern commented Jul 22, 2019

@pytorchbot retest this please

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 22, 2019

@mrshenli merged this pull request in 8bc28cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli mrshenli approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@pietern pietern Awaiting requested review from pietern

Assignees

No one assigned

Labels

Merged module: cuda Related to torch.cuda, and CUDA support in general module: nccl Problems related to nccl support module: pybind Related to our Python bindings / interactions with other Python libraries oncall: distributed Add this issue/PR to distributed oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jeffdaily @mrshenli @pietern @facebook-github-bot @ezyang @pytorchbot @mruberry