[tensorboard] Cleanup API and remove 'experimental' warning #23000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Landing one more time. This cleans up the `torch.utils.tensorboard` API to remove all kwargs usage (which isn't clear to the user) and removes the "experimental" warning in prep for our 1.2 release. We also don't need the additional PyTorch version checks now that we are in the codebase itself. cc ezyang lanpa natalialunova
orionr
force-pushed
the
fix-tensorboard-asan-test
branch
from
a38c1bf to
a232d3b
Compare
pytorchbot
added
module: docs
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
changed the title
orionr
changed the title
Contributor
Author
|
@pytorchbot retest this please |
orionr
changed the title
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Test failures look to be unrelated. ASAN checks passed. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ASAN test issues with #21786 seen at https://circleci.com/api/v1.1/project/github/pytorch/pytorch/2212325/output/105/0?file=true and lands it again.
This cleans up the
torch.utils.tensorboardAPI to remove all kwargs usage (which isn't clear to the user) and removes the "experimental" warning in prep for our 1.2 release.We also don't need the additional PyTorch version checks now that we are in the codebase itself.
cc @yf225, @lanpa, @natalialunova