Add missing comment from #22103 #22984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One important comment is missing from pytorch#22103 (not sure what happened). This commit makes it up.
pytorchbot
added
module: cuda
li-roy
approved these changes
Jul 17, 2019
pytorchbot
added
the
merge-this-please
xuhdev
removed
the
merge-this-please
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2019
Summary: One important comment is missing from pytorch/pytorch#22103 (not sure what happened). This commit makes it up. Pull Request resolved: pytorch/pytorch#22984 Differential Revision: D16347044 Pulled By: ezyang fbshipit-source-id: 0903909a5fb6740b43195136f1a23c28cfb2a02f
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One important comment is missing from #22103 (not sure what happened).
This commit makes it up.