disable non-deterministic cudnn ctcloss #22977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI: I'm not sure if writing "Associated issue" will automatically close the issue, but writing "Fixes: " will. |
ssnl
reviewed
Jul 17, 2019
aten/src/ATen/native/LossCTC.cpp
Outdated
| Tensor res; | ||
| if (use_cudnn) { | ||
| res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, ctx.deterministicCuDNN(), zero_infinity)); | ||
| res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, true, zero_infinity)); |
gchanan
approved these changes
Jul 17, 2019
aten/src/ATen/native/LossCTC.cpp
Outdated
| Tensor res; | ||
| if (use_cudnn) { | ||
| res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, ctx.deterministicCuDNN(), zero_infinity)); | ||
| res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, true, zero_infinity)); |
Contributor
There was a problem hiding this comment.
nit: can you just add a comment explaining the issue?
gchanan
approved these changes
Jul 17, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@nairbv is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2019
Summary: Associated issue: pytorch/pytorch#21680 Pull Request resolved: pytorch/pytorch#22977 Differential Revision: D16357873 Pulled By: nairbv fbshipit-source-id: 58711bac7d3e8390e868d594dc265ba053a1537c
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issue: #21680