Skip to content

Conversation

@driazati
Copy link
Contributor

@driazati driazati commented Jul 16, 2019

  • better error in toSugaredValue
  • removes a bunch of periods on error messages, ErrorReport already adds a : at the end of the message
    Differential Revision: D16291079

@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: pybind Related to our Python bindings / interactions with other Python libraries labels Jul 16, 2019
@driazati driazati requested review from suo and wanchaol July 16, 2019 21:50
davidriazati added 2 commits July 16, 2019 14:58
@facebook-github-bot
Copy link
Contributor

@driazati merged this pull request in ef36046.

@facebook-github-bot facebook-github-bot deleted the driazati/errors/1 branch July 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants