Remove usage of legacy autograd function #22925
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: autograd
Contributor
|
You should kill uses NestedIOFunction too, as it is also in legacy style. |
Contributor
Author
|
I would like to scope out |
yf225
force-pushed
the
remove_legacy_function_usage
branch
from
0f5b10d to
d85b098
Compare
ezyang
reviewed
Jul 17, 2019
| rx, ry = NoneGradientFunction.apply(x, y) | ||
| rx.register_hook(hook) | ||
| ry.register_hook(hook) | ||
| sum(rx, ry).sum().backward() |
ezyang
reviewed
Jul 17, 2019
ezyang
approved these changes
Jul 17, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Looks good, thank you. Note that this PR reduces our test coverage of legacy autograd functions, which means that we are less likely to notice breakages of legacy once we land it.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to put up a deprecation warning for legacy autograd function in 1.2: #22922. This PR removes all usage of legacy function in PyTorch core and test suite, to prepare for the eventual removal of legacy function.