Reapply: optimize topk on cpu using parallel and partial sort (#19736) #22865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rallel and partial sort" This reverts commit 35ee4bf.
pytorchbot
added
module: cpu
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Tests all green. |
kostmo
approved these changes
Jul 18, 2019
Contributor
|
@VitalyFedyunin merged this pull request in 425d28c. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2019
…) (#22865) Summary: pytorch/pytorch#19736 was reverted as it was suspected to be broken on the master, trying to reapply Pull Request resolved: pytorch/pytorch#22865 Differential Revision: D16265457 Pulled By: VitalyFedyunin fbshipit-source-id: 784bd6405471f15a8a49ebd0f3e98160d7d0679e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19736 was reverted as it was suspected to be broken on the master, trying to reapply