Bidirectional GRU and LSTM C++ API forward fix #22850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You've unintentionally updated the submodule "third_party/fbgemm". I think you can |
zou3519
reviewed
Jul 15, 2019
zou3519
reviewed
Jul 15, 2019
…eForward_CUDA tests
Contributor
|
Tests aren't running, this might need a rebase |
zou3519
approved these changes
Jul 22, 2019
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
lgtm, thanks! Some minor comments on making the tests nicer.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pbelevich merged this pull request in 965b97f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #17998