[fixing reduction kernel launch] #22827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix out of range memory access for reduction on all dimensions for non-packed tensor. 2. Enabling launch config that maps block width to reduction on fastest striding dimension. This mapping was previously only active when reducing on fastest striding dimension of packed tensor, which is not necessary.
pytorchbot
added
module: cuda
Collaborator
Author
Contributor
|
@jjsjann123 feel free to request review |
jerryzh168
added
the
triaged
Collaborator
Author
|
Looks like bunch of tests failed here. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
approved these changes
Jul 15, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good. Ill land when the tests pass.
Collaborator
Author
|
I don't have a local repro on circleci failure build failure looks strange as well. I don't think I have messed up history :/ |
Contributor
|
@zdevito Could you land this PR? Thanks. |
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 19, 2019
Summary: 1. Fix out of range memory access for reduction on all dimensions for non-packed tensor. 2. Enabling launch config that maps block width to reduction on fastest striding dimension. This mapping was previously only active when reducing on fastest striding dimension of packed tensor, which is not necessary. Pull Request resolved: pytorch/pytorch#22827 Differential Revision: D16271897 Pulled By: zdevito fbshipit-source-id: 20763f6cf9a58e44ffc0e7ec27724dfec8fe2c5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix out of range memory access for reduction on all dimensions for non-packed
tensor.
Enabling launch config that maps block width to reduction on fastest striding
dimension. This mapping was previously only active when reducing on fastest
striding dimension of packed tensor, which is not necessary.