Skip to content

Conversation

@suo
Copy link
Member

@suo suo commented Jul 10, 2019

Stack from ghstack:

This makes it so that all code objects owned by a CompilationUnit will
have a qualified name.

This also means that Module performs one new duty: it does
qualified name resolution by concating the Module qualified name with
the method name to find the method in the owning CU.

gh-metadata: pytorch pytorch 22711 gh/suo/83/head

This makes it so that all code objects owned by a CompilationUnit will
have a qualified name.

This also means that Module performs one new duty: it does
qualified name resolution by concating the Module qualified name with
the method name to find the method in the owning CU.
[jit] Give functions qualified names

This makes it so that all code objects owned by a CompilationUnit will
have a qualified name.

This also means that Module performs one new duty: it does
qualified name resolution by concating the Module qualified name with
the method name to find the method in the owning CU.

gh-metadata: pytorch pytorch 22711 gh/suo/83/head
@suo suo closed this Jul 11, 2019
@facebook-github-bot facebook-github-bot deleted the gh/suo/83/head branch October 28, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: cpp Related to C++ API oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants