fix negative string indexing #22700
Closed
fix negative string indexing #22700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanchaol
reviewed
Jul 10, 2019
| auto index = pop(stack).toInt(); | ||
| auto string = pop(stack).toStringRef(); | ||
| char c = string.at(index); | ||
| auto norm_index = normalizeIndex(index, string.size()); |
Collaborator
There was a problem hiding this comment.
can you modify the __getitem__ overload for string instead? I think we plan to deprecate those prim operators and all using aten::__getitem__ for indexing #22276
wanchaol
approved these changes
Jul 24, 2019
Collaborator
wanchaol
left a comment
wanchaol
left a comment
There was a problem hiding this comment.
looks good, CI is broken though
Contributor
Author
|
@pytorchbot rebase this please |
eellison
force-pushed
the
neg_str_index
branch
from
a36bae5 to
73b942f
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings allow negative indexing in python