Skip to content

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 8, 2019

Some overlap with #21716 regarding caffe2 nonzero. Will rebase the other one accordingly whichever gets merged first.

@pytorchbot pytorchbot added caffe2 module: onnx Related to torch.onnx labels Jul 8, 2019
@li-roy li-roy requested a review from houseroad July 10, 2019 08:03
@li-roy li-roy added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 10, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in eb5137a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

caffe2 Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants