Skip to content

[ONNX] Export torch.masked_fill with onnx::where #22521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BowenBao wants to merge 3 commits into from
Closed

[ONNX] Export torch.masked_fill with onnx::where #22521

BowenBao wants to merge 3 commits into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jul 4, 2019

No description provided.

@pytorchbot pytorchbot added the module: onnx Related to torch.onnx label Jul 4, 2019
spandantiwari
spandantiwari approved these changes Jul 5, 2019
View reviewed changes
Copy link

@spandantiwari spandantiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should blacklist it for Opset 7 and 8 export PR (#22421) because Where op is not available before that.

@zou3519
Copy link
Contributor

zou3519 commented Jul 8, 2019

@houseroad can you land this?

@zou3519 zou3519 requested a review from houseroad July 8, 2019 18:30
facebook-github-bot
facebook-github-bot reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

houseroad commented Jul 8, 2019

Sure, I will take a look

facebook-github-bot
facebook-github-bot reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you resolve the conflict?

facebook-github-bot
facebook-github-bot reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2019

@houseroad merged this pull request in 52de340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

+1 more reviewer

@spandantiwari spandantiwari spandantiwari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BowenBao @zou3519 @houseroad @facebook-github-bot @spandantiwari @ezyang @pytorchbot @mruberry