[jit] Make classtypes hold a weak_ptr to their CU #22504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
This was referenced Jul 3, 2019
[WIP] classtypes hold weak_ptr gh-metadata: pytorch pytorch 22504 gh/suo/77/head
[WIP] classtypes hold weak_ptr gh-metadata: pytorch pytorch 22504 gh/suo/77/head
[WIP] classtypes hold weak_ptr gh-metadata: pytorch pytorch 22504 gh/suo/77/head
This was referenced Jul 10, 2019
[jit] Make classtypes hold a weak_ptr to their CU This breaks the ownership cycle between modules and their functions. gh-metadata: pytorch pytorch 22504 gh/suo/77/head
This was referenced Jul 10, 2019
suo
changed the title
[jit] Make classtypes hold a weak_ptr to their CU This breaks the ownership cycle between modules and their functions. gh-metadata: pytorch pytorch 22504 gh/suo/77/head
[jit] Make classtypes hold a weak_ptr to their CU This breaks the ownership cycle between modules and their functions. gh-metadata: pytorch pytorch 22504 gh/suo/77/head
[jit] Make classtypes hold a weak_ptr to their CU This breaks the ownership cycle between modules and their functions. gh-metadata: pytorch pytorch 22504 gh/suo/77/head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This breaks the ownership cycle between modules and their functions.
gh-metadata: pytorch pytorch 22504 gh/suo/77/head
Differential Revision: D16121782